Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-43248-upgrade-catch2-library #90

Merged
merged 3 commits into from
Dec 5, 2024
Merged

DOCSP-43248-upgrade-catch2-library #90

merged 3 commits into from
Dec 5, 2024

Conversation

gmiller-mdb
Copy link
Collaborator

@gmiller-mdb gmiller-mdb commented Dec 4, 2024 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43248
Staging - https://deploy-preview-90--docs-cpp.netlify.app/upgrade/#version-3.11

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify Netlify
Copy link

netlify bot commented Dec 4, 2024 •
edited
Loading

✅ Deploy Preview for docs-cpp ready!

Name Link
🔨 Latest commit 8230dbf
🔍 Latest deploy log https://app.netlify.com/sites/docs-cpp/deploys/67521237eff26700083d28bb
😎 Deploy Preview https://deploy-preview-90--docs-cpp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

norareidy
norareidy requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left a few comments

source/upgrade.txt Outdated Show resolved Hide resolved
source/upgrade.txt Outdated Show resolved Hide resolved
source/upgrade.txt Outdated Show resolved Hide resolved
@gmiller-mdb gmiller-mdb requested a review from norareidy December 4, 2024 21:07
norareidy
norareidy approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gmiller-mdb gmiller-mdb requested a review from kevinAlbs December 5, 2024 19:08
kevinAlbs
kevinAlbs approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggested rewording.

source/upgrade.txt Outdated Show resolved Hide resolved
@gmiller-mdb gmiller-mdb merged commit d0e7651 into mongodb:master Dec 5, 2024
5 checks passed
norareidy pushed a commit that referenced this pull request Dec 10, 2024
@gmiller-mdb @norareidy
DOCSP-43248-upgrade-catch2-library (#90)
64774e0 
* DOCSP-43248-upgrade-catch2-library

* fix copy

* rewording

(cherry picked from commit d0e7651)
norareidy pushed a commit that referenced this pull request Dec 10, 2024
@gmiller-mdb @norareidy
DOCSP-43248-upgrade-catch2-library (#90)
c203cfd 
* DOCSP-43248-upgrade-catch2-library

* fix copy

* rewording

(cherry picked from commit d0e7651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norareidy norareidy norareidy approved these changes

@kevinAlbs kevinAlbs kevinAlbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmiller-mdb @kevinAlbs @norareidy